Re: [PATCH]:(remake) missing /dev/stX & /dev/nstX even if rescue mode

[HARA Hiroshi <hhara miraclelinux com>]

> What version of anaconda are you testing against here?  dlehman added
> support for creating the tape device nodes in iutil.makeDriveDeviceNodes
> for 11.3.0.6-1, and this should work in rescue mode as well.
I evaluated that patch with kernel-2.6.18 and kudzu-1.2.57.1.13-1.
this combination can not work well.
because the following "kudzu.probe" return devs which include
"CLASS_TAPE" but dev.device for "CLASS_TAPE" is "None"
--------------------------
....
....
def driveDict(klassArg):
    import parted
    global cachedDrives
    if cachedDrives is None:
        # FIXME: need to add dasd probing to kudzu
        devs = kudzu.probe(kudzu.CLASS_HD | kudzu.CLASS_CDROM | \
                           kudzu.CLASS_FLOPPY | kudzu.CLASS_TAPE,
                           kudzu.BUS_UNSPEC, kudzu.PROBE_SAFE)
        new = {}
        for dev in devs:
            device = dev.device
            if device is None: # none devices make no sense
                continue   <--Here
....
....
---------------------------------------------


the following is the results of "kudzu.probe" on rescue mode.
(Device is None)
----------------------------------------------
sh-3.1# python
...
...
>>> import kudzu
>>> kudzu.probe(kudzu.CLASS_TAPE, kudzu.BUS_UNSPEC, kudzu.PROBE_SAFE)
[Desc:           SONY SDT-10000
Driver:         None
Device:         None
]
>>>
----------------------------------------------

and then I also have read kudzu.
I thought we need to modify kudzu/scsi.c(scsiProbe) and
kudzu/kudzu.c(__getSysfsDevice and so on (devCmp..)...)

if kudzu is modified, i think current iutil.makeDriveDeviceNodes
will be fine.
but if kudzu is not modified, my previous patch can create
"/dev/stX" and "/dev/nstX".(not create st0a, st0m.....)


---
additionally, even if kudzu.prove return devs and
dev.device is "st0", iutil.makeDriveDeviceNodes can not create
"/dev/st0".
see the attached patch.(if multi tape device will be supported,
we need add "nst1", "st1","nst2", "st2".....)





> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


diff -u -r1.42 devnodes.c
--- isys/devnodes.c     17 Nov 2005 00:16:42 -0000      1.42
+++ isys/devnodes.c     6 Aug 2007 10:56:07 -0000
@@ -57,6 +57,7 @@
     { "mcd",           23,     0,      0 },
     { "mcdx",          20,     0,      0 },
     { "nst0",          9,      128,    1 },
+    { "st0",           9,      0,      1 },
     { "optcd",         17,     0,      0 },
     { "psaux",         10,     1,      1 },
     { "sbpcd",         25,     0,      0 },