On Fri, 22 Jun 2007 10:07:58 +0800 Dawei Pang <dwpang redflag-linux com> wrote: > Hi, > The patch can fix three problem of iscsi configuration. > In GUI install method, > 1. choose "Add iSCSI target" and add driver, anaconda will show the > "Enable network interface", after configuring network, press OK, it will > return to the partition method page, it should go to the iscsi > configuration. > 2. we need use _handleIPMissing function in the netconfig_dialog.py so > as to handle IPMissing exception like class NetworkWindow of network_gui.py. > 3. when isys.configNetDevice() raise an exception in the > netconfig_dialog.py, I think anaconda should show error window, not only > use log.error() > Please check the patch,thank you very much. Had a similar patch sent to the list yesterday. I've incorporated changes from your patch. The other patch just added except statements and used the existing self._handleIPError. I added your _handleIPMissing function and modified the except statements to use that. I did not include the IPMissing except for the Nameserver as that field is not required (see the 'if ns:' under the try:). Other than that, looks good. Applying it to anaconda in rawhide. Thanks, -- David Cantrell <dcantrell redhat com> Red Hat / Westford, MA
Attachment:
pgpMV32bcNBNF.pgp
Description: PGP signature