Re: Need to support CIDR prefix at Add iSCSI target setup

[HARA Hiroshi <hhara miraclelinux com>]

Hi, David

David Cantrell wrote:
> On Fri, 22 Jun 2007 23:21:08 +0900
> HARA Hiroshi <hhara miraclelinux com> wrote:
> 
>> After I sent you the netconfig_dialog.py.diff yesterday,
>> I think that it is better that anaconda supports
>> CIDR prefix at Add iSCSI target setup.
>> (I'm sorry for bothering you.)
>>
>> Would you review my additional patch, please ?
> 
> There's been a lot of outside work on this area of anaconda lately, which is great.  I just committed some other changes to the netconfig_dialog.py file earlier.
> 
> Regarding your patch... I made the following changes when applying it:
> 
> 1) Changed Netmask to 'IPv4 Network Mask' in dialog box titles.
> 2) When you use prefix2netmask to convert the prefix to a netmask, you forget to set it in netdev (and sanity check it), so I added that.
so, about 2) "sanity check" is also needed?
so also attached patch is also useful ?
> 
> Other than that, looks good.  Thanks!
thank you

diff -u -r1.110 network_gui.py
--- iw/network_gui.py   23 Mar 2007 21:40:19 -0000      1.110
+++ iw/network_gui.py   22 Jun 2007 16:13:59 -0000
@@ -797,7 +797,9 @@
                             self.valid_input = 1
                             return
                         else:
-                            self.ipv4_prefix.set_text(isys.prefix2netmask(int(val)))
+                            val = isys.prefix2netmask(int(val))
+                            network.sanityCheckIPString(val)
+                            self.ipv4_prefix.set_text(val)
                     except:
                         self.netwin.handleIPMissing('IPv4 network mask')
                         self.valid_input = 1