Peter Jones さんは書きました:
HARA Hiroshi wrote:Hi, I saw our anaconda was started to manage with git in Jeremy's mail.(thanks, Jeremy) so I used it and it's fine for me. then I modified the patch which I have sent before. Current insmod in anaconda has no check point after allocating memory (malloc/strdup/realloc). so I added such kind of check point. I'd appreciate it if you could review this attached patch.Used %m instead of %s + strerror(errno), but other than than applied as sent.
Hi, Thank you for your reviewing. I have found that there are a lot of "%s + strerror(errno)" in anaconda code. but as you mentioned, I also feel that "%m" is a little more simple than "%s + strerror(errno)". so I'll sent later the patch which clean up "%s + strerror" in anaconda. and then I'd appreciate it if you also could review the patch. thank you,