Re: [PATCH] traceback looking for existing roots (rawhide #473498)

[David Cantrell <dcantrell redhat com>]

Dave Lehman wrote:
> I've attached a simple patch that will fix the traceback, but I admit I
> am a little confused how this came to be an issue. Reporter says he/she
> has encrypted PV, which presumably is what triggers the traceback. The
> thing is that we try to skip such partitions -- the only way this can
> happen is if the partition is not active (whatever the hell that means)
> or it is a PV in spite of having some other partition type. I guess
> there isn't anything we can do in either case?
> 
> Anyway, the patch to just fix the traceback is trivial:
> 
> diff --git a/partedUtils.py b/partedUtils.py
> index f7b9f67..4be0486 100644
> --- a/partedUtils.py
> +++ b/partedUtils.py
> @@ -873,6 +873,7 @@ class DiskSet:
>                      continue
>                  elif part.fs_type or crypto:
>                      theDev = node
> +                    fstype = None
>                      if part.fs_type:
>                          fstype = part.fs_type.name
>  

I see no other comments to this patch.  I'm all for trivial fixes to
prevent tracebacks.

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI