Re: [PATCH] Better naming for LVM volume groups and logical volumes (#461682)

[Jeremy Katz <katzj redhat com>]

On Mon, 2008-12-01 at 12:03 -1000, David Cantrell wrote:
> +    # try to create a volume group name incorporating the hostname
> +    if network.hostname is not None and network.hostname != '':
> +        if network.hostname.find('.') != -1:
> +            vgtemplate = "vg_%s" % (network.hostname.split('.')[0].lower(),)
> +        else:
> +            vgtemplate = "vg_%s" % (network.hostname.lower(),)
> +    else:
> +        vgtemplate = "VolGroup"

The other comment I'd have beyond Hans's is if the hostname is localhost
or localhost.localdomain, we should probably just fall back to the
VolGroup case as well.

Jeremy