Re: [PATCH] have anaconda write anacdump.txt on demand

[David Cantrell <dcantrell redhat com>]

David Lehman wrote:
>> I thought it'd be nice if we could generate an anacdump.txt on demand,
>> to help debug where anaconda's stuck but hasn't crashed.  The attached
>> patch causes anaconda to write /tmp/anacdump.txt when SIGUSR2 is
>> received.  It requires the stuff Peter just mailed.
> 
> Nice idea.
> 
> What I don't like is adding new code to isys to do things we can easily
> do in pure python. Attached are two patches. The first one changes our
> current code to use stacks instead of tracebacks in
> AnacondaExceptionDump. It contains the same information, just in a
> slightly different form. What we gain is the ability to generate
> traceback-like data by simply calling inspect.stack() instead of having
> to resort to growing isys. To be clear, this first patch is intended as
> an alternative to Peter's isys.traceback patch.
> 
> The second patch is just an update of Chris' original patch that uses
> the aforementioned modifications.
> 
> Again, the only thing we gain here is not growing isys. Otherwise the
> two approaches are functionally equivalent as verified by diffing two
> artificially generated anacdump.txt files.
> 

I like it, especially having it all in Python.

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI