[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: PATCH: fix various *syntax* errors in master



Hans de Goede wrote:
> Hi all,
> 
> This patch fixes the following syntax errors caught by pychecker:
> iw/lvm_dialog_gui.py:1024: Invalid arguments to (createSuggestedVGName),
> got 1,
> expected 2
> iw/welcome_gui.py:67: No global (sys) found
> textw/network_text.py:75: No global (herrors) found
> textw/welcome_text.py:44: No global (sys) found
> 
> I choose to rename neterrors to herrors, instead of replacing the use of
> the
> undefined herrors with neterrors, to make things identical between
> textmode and
> gui mode, to avoid copy and paste errors like this one in the future.
> 
> Regards,
> 

Looks good.

-- 
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]