[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] pykickstart, pungi: Allow ignoring of group metadata from repos



Chris Lumens (clumens redhat com) said: 
> You shouldn't need __str__ or methodToRepo in F11_Repo, since they
> should all be inherited.  I should probably remove __str__ from F8_Repo
> as well since it's in FC6_Repo.  Other than that, looks fine.

Removed.

>  If you've
> got commit access to pykickstart, go ahead and commit.  You can also try
> running make check in the pykickstart tree after committing but before
> pushing, just to make sure.

Passed check, pushed.

Thanks for the review,
Bill


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]