[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH](resend)Fix gtk.MessageDialog Exception
- From: Chris Lumens <clumens redhat com>
- To: anaconda-devel-list redhat com
- Subject: Re: [PATCH](resend)Fix gtk.MessageDialog Exception
- Date: Wed, 23 Jan 2008 10:20:10 -0500
> anaconda sometimes calls anaconda.intf.messageWindow with
> exceptions.ValueError like this.
> But gtk.MessageDialog in messageWindow can not accept it.
>
> so I added str() to gtk.MessageDialog like the attached patch.
> ----------------------
> self.dialog = gtk.MessageDialog(mainWindow, 0, style, buttons, str(text))
> ----------------------
>
> or should I change all of calling side like the following?
> ----------------------
> self.intf.messageWindow(_("Error"), str(e))
> or
> self.intf.messageWindow(_("Error"), "%s" %(e,))
> ----------------------
I'd prefer to change the callers wherever possible, but since we keep
running into this problem I think it probably makes sense to fix it in
both places. I'll apply the patch.
- Chris
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]