Re: [PATCH] - Code cleanup - handling of --serial

[Alexander Todorov <atodorov redhat com>]

Alexander Todorov wrote:
... skip ...
> No need to have the same block of code twice in an if-else statement.

Can someone review this please. It's and easy fix. Just some code cleanup.

---

diff --git a/loader2/loader.c b/loader2/loader.c
index 2740ae4..fb1738b 100644
--- a/loader2/loader.c
+++ b/loader2/loader.c
@@ -1995,13 +1995,12 @@ int main(int argc, char ** argv) {
     if (FL_NOIPV6(flags))
         *argptr++ = "--noipv6";

+    if (FL_SERIAL(flags))
+        *argptr++ = "--serial";
+
     if (FL_RESCUE(flags)) {
         *argptr++ = "--rescue";
-        if (FL_SERIAL(flags))
-            *argptr++ = "--serial";
     } else {
-        if (FL_SERIAL(flags))
-            *argptr++ = "--serial";
         if (FL_TEXT(flags))
             *argptr++ = "-T";
         else if (FL_GRAPHICAL(flags))




Thanks,
Alexander.