[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: Getting rid of our remaining rhpl dependencies
- From: Jeremy Katz <katzj redhat com>
- To: Discussion of Development and Customization of the Red Hat Linux Installer <anaconda-devel-list redhat com>
- Subject: Re: Getting rid of our remaining rhpl dependencies
- Date: Tue, 03 Jun 2008 20:14:16 -0400
On Tue, 2008-06-03 at 12:10 -1000, David Cantrell wrote:
> On Jun 3, 2008, at 11:57 AM, Jeremy Katz wrote:
> > On Tue, 2008-06-03 at 11:48 -1000, David Cantrell wrote:
> >> On Jun 3, 2008, at 11:03 AM, Jeremy Katz wrote:
> >>> So rhpl has over time turned into something of a dumping ground and
> >>> we're really not using it for much any more. This probably means
> >>> it's
> >>> getting close to its time to go away (much like was done with
> >>> pythonlib
> >>> before).
> >>>
> >>> Left in anaconda[1] are really just a couple of uses of rhpl
> >>> * rhpl.getArch() -- We mvoed this out of iutil, we could easily move
> >>> it
> >>> back
> >>
> >> I've never liked rhpl.getArch() and would really like to see it go
> >> away completely. Uses of it in anaconda sort of hide what values you
> >> are really testing for. When you rhpl.getArch() hands you 's390',
> >> that really means s390 and s390x. And so on. I would prefer to
> >> explicitly test os.uname().
> >
> > That gets a little ugly, just due to the multitude of uname returns
> > for
> > i386. But it's definitely doable.
>
> I'm thinking functions like:
>
> isPPC()
> isX86()
> isS390()
Sounds good to me; probably in iutil, just because isys is (nominally)
things which are binding something written in C. Anyone want to
volunteer to do this? It should be a pretty straight-forward patch
Jeremy
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]