[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] remove rhpl.getArch() calls



David Cantrell wrote:


2) isX86() returns true for 32-bit and 64-bit x86 processors, but you can pass bits=[32|64] to test just one subset (this is used in getArch further down).


As one inclined to defensive programming, I would prefer that users be explicit as to whether word size matters.

The fact you needed to explain it suggest you agree that there's room for confusion.
How about bits=[32|64|any]?

and similarly in other architecture tests.

--

Cheers
John

-- spambait
1aaaaaaa coco merseine nu  Z1aaaaaaa coco merseine nu
-- Advice
http://webfoot.com/advice/email.top.php
http://www.catb.org/~esr/faqs/smart-questions.html
http://support.microsoft.com/kb/555375

You cannot reply off-list:-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]