[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: minor nit in keymap patch



Bill, thanks for the review. Clearly it was needed :/

> You never source /etc/sysconfig/i18n here, so you'll get 'whatever language
> mkinitrd is run in', as opposed to the 'system' language.

I'll push a fix in a couple of minutes.

> 
> Stepping back, when this is run in the kernel's %post in anaconda, are we sure:
> - that /etc/sysconfig/i18n and /etc/sysconfig/keyboard are written

Ugh. I'll have to look into this mess.

> - that kbd has actually been installed to lay down the keyboard maps

kbd is a mandatory member of core, but I'm not done looking at
transaction ordering.

> - that the console keymap is 'close enough' to the X keymap?

For F9, there isn't anything I can do about this that I know of.


Dave



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]