Re: Some *real* issues reported by PyChecker, where I'm not sure how to fix them

[Hans de Goede <hdegoede redhat com>]

Chris Lumens wrote:
> > partedUtils.py:1143: No module attribute (formatException) found
>
> This should be something like this:
>
> exn = exception.AnacondaExceptionDump(type, value, tb)
> lines = exn.__str__()
> ...

Fixed, thanks.

> > text.py:161: No class attribute (scpNameEntry) found
> > text.py:162: No class attribute (scpPasswordEntry) found
> > text.py:163: No class attribute (scpHostEntry) found
> > text.py:164: No class attribute (scpDestEntry) found
> > text.py:169: No class attribute (scpNameEntry) found
> > text.py:170: No class attribute (scpPasswordEntry) found
> > text.py:171: No class attribute (scpHostEntry) found
> > text.py:172: No class attribute (scpDestEntry) found
> > text.py:177: No class attribute (scpNameEntry) found
> > text.py:178: No class attribute (scpPasswordEntry) found
> > text.py:179: No class attribute (scpHostEntry) found
> > text.py:180: No class attribute (scpDestEntry) found
> > text.py:192: No class attribute (scpNameEntry) found
> > text.py:193: No class attribute (scpPasswordEntry) found
> > text.py:194: No class attribute (scpHostEntry) found
> > text.py:195: No class attribute (scpDestEntry) found
> >
> > I think this is some old cruft and we should just nuke all these lines, 
> > but I'm not sure.
>
> When I was doing the save-to-bugzilla thing, the first run of my patch
> removed support for saving via SCP.  That didn't go over well on the
> list so I added it back in.  I must have missed it in text mode.  I'm
> not opposed to removing the last vestiges of SCP support from text mode
> but that may still not be a popular opinion.

Well if you broke it, you get the keep both pieces, or rather you get to fix 
it. I don't have an opinion as to how to fix this.

Regards,

Hans