[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
PATCH: Fix the last pychecker warnings in master
- From: Hans de Goede <hdegoede redhat com>
- To: Discussion of Development and Customization of the Red Hat Linux Installer <anaconda-devel-list redhat com>
- Subject: PATCH: Fix the last pychecker warnings in master
- Date: Thu, 30 Oct 2008 10:23:38 +0100
Hi All,
As described in $SUBJECT
Note I've verified that clickCB() in the last chunk always returns True or False.
Regards,
Hans
diff --git a/autopart.py b/autopart.py
index f335602..ff62f37 100644
--- a/autopart.py
+++ b/autopart.py
@@ -198,7 +198,7 @@ class partlist:
def getMinimumSector(disk):
if disk.type.name == 'sun':
start = long(disk.dev.sectors * disk.dev.heads)
- start /= (1024 / disk.dev.sector_size)
+ start /= long(1024 / disk.dev.sector_size)
return start + 1
return 0L
diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index 00727ae..58793b7 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -88,7 +88,7 @@ class VolumeGroupEditor:
pesize = 32768
pvreq = self.partitions.getRequestByID(id)
pvsize = pvreq.getActualSize(self.partitions, self.diskset)
- pvsize = lvm.clampPVSize(pvsize, pesize) - (pesize/1024)
+ pvsize = lvm.clampPVSize(pvsize, pesize) - int(pesize/1024)
if first:
minpvsize = pvsize
first = 0
diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py
index bda0914..e2ef4a7 100644
--- a/iw/partition_ui_helpers_gui.py
+++ b/iw/partition_ui_helpers_gui.py
@@ -48,7 +48,7 @@ class WideCheckList(checklist.CheckList):
if self.clickCB:
rc = self.clickCB(data, row)
- if rc == True:
+ if rc:
checklist.CheckList.toggled_item(self, data, row)
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]