[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] 469171 - calling newtWinMessage before startNewt



> > Is there any reason we can't just call startNewt a lot earlier in main
> > instead of playing the game of calling it as-needed a million other
> > places?
> 
> The idea of lazily starting it is that we don't end up doing the blue
> screen if we have everything we need to get to stage2 without any
> dialogs, etc.  Then again, given our present flow, that's probably not a
> likely case what with waiting for devices to settle, etc

Yeah true.  I just see a ton of places (especially in the networking
code right now) where newtWinMessage can be called to display an error,
but we are not guaranteed to ever have called startNewt.  This is the
fun of the kickstart/cmdline vs. interactive flow all being mixed
together.

I could alternatively go and add some more startNewt calls here and
there.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]