Re: [PATCH] pyblock: RaidSet.level is broken atm

[Joel Granados <jgranado redhat com>]

looks good
On Wed, Apr 01, 2009 at 05:08:22PM +0200, Hans de Goede wrote:
> RaidSet.level is broken atm, make this very clear to anyone trying to use it.
> ---
>  device.py |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/device.py b/device.py
> index 039c55a..7134cfb 100644
> --- a/device.py
> +++ b/device.py
> @@ -637,11 +637,13 @@ class RaidSet:
>      PedDevice = property(get_PedDevice, None, None, "parted.PedDevice")
>  
>      def get_level(self):
> +        # We do not handle layered raid properly here, nor raid5 nor JBOD
> +        raise NotImplementedError, "FIXME"
>          if self.rs.dmtype in ("stripe", "striped"):
>              return 0
>          elif self.rs.dmtype == "mirror":
>              return 1
> -        raise NotImplementedError, "unknown dmtype %s" % (rs.dmtype,)
> +        raise NotImplementedError, "unknown dmtype %s" % (self.rs.dmtype,)
>      level = property(get_level, None, None, "raid level")
>  
>      def get_members(self, descend=True):
> -- 
> 1.6.2
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.