Re: [PATCH] Remove DmRaidArrayDevice level attribute (#493293)

[Joel Granados <jgranado redhat com>]

looks ok.
On Wed, Apr 01, 2009 at 05:11:52PM +0200, Hans de Goede wrote:
> Remove the DmRaidArrayDevice level attribute, pyblock's RaidSet.level
> property is broken causing issues when calling it, and we do not use
> the level attribute anywhere.
> ---
>  storage/devices.py    |    4 +---
>  storage/devicetree.py |    1 -
>  2 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 845a46b..32e4c23 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2333,7 +2333,7 @@ class DMRaidArrayDevice(DiskDevice):
>      _packages = ["dmraid"]
>      _devDir = "/dev/mapper"
>  
> -    def __init__(self, name, raidSet=None, level=None, format=None,
> +    def __init__(self, name, raidSet=None, format=None,
>                   size=None, major=None, minor=None, parents=None,
>                   sysfsPath='', initcb=None, initlabel=None):
>          """ Create a DMRaidArrayDevice instance.
> @@ -2345,7 +2345,6 @@ class DMRaidArrayDevice(DiskDevice):
>              Keyword Arguments:
>  
>                  raidSet -- the RaidSet object from block
> -                level -- the type of dmraid
>                  parents -- a list of the member devices
>                  sysfsPath -- sysfs device path
>                  size -- the device's size
> @@ -2369,7 +2368,6 @@ class DMRaidArrayDevice(DiskDevice):
>  
>  
>          self._raidSet = raidSet
> -        self._level = level
>  
>      @property
>      def raidSet(self):
> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index d87c5af..4a1aeba 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -1292,7 +1292,6 @@ class DeviceTree(object):
>                              dm_array = DMRaidArrayDevice(rs.name,
>                                                      major=major, minor=minor,
>                                                      raidSet=rs,
> -                                                    level=rs.level,
>                                                      parents=[device],
>                                                      initcb=cb,
>                                                      initlabel=initlabel)
> -- 
> 1.6.2
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.