Re: [PATCH] Create setup and teardown functs for dmraid devs.

[Joel Granados <jgranado redhat com>]

On Thu, Apr 02, 2009 at 10:20:40AM -0500, David Lehman wrote:
> On Thu, 2009-04-02 at 17:11 +0200, Joel Granados Moreno wrote:
> > * storage/devices.py (DMRaidArrayDevice): Erase the activate and
> >   deactivate functions for the DMRaidArrayDevice.  They are no really
> >   being used.
> > * storage/devices.py (DMRaidArrayDevice): Create setup and teardown
> >   functions for the class.
> > * storage/devices.py (Device): Add the pyblock attribute to the shallow
> >   copy list.
> 
> Looks good to me as long as there is no chance that the members of a
> dmraid could be devices that we need to deactivate if given the
> recursive argument.

When we call rs.deactivate it is a recursive call, for raid10 and jbod.
So no chance of this happening.

regards.
> 
> > ---
> >  storage/devices.py |   32 +++++++++++++++++++++++++-------
> >  1 files changed, 25 insertions(+), 7 deletions(-)
> > 
> > diff --git a/storage/devices.py b/storage/devices.py
> > index 32e4c23..da9aacc 100644
> > --- a/storage/devices.py
> > +++ b/storage/devices.py
> > @@ -201,7 +201,8 @@ class Device(object):
> >          new = self.__class__.__new__(self.__class__)
> >          memo[id(self)] = new
> >          shallow_copy_attrs = ('partedDisk', 'partedDevice',
> > -                             '_partedPartition', '_origPartedDisk')
> > +                             '_partedPartition', '_origPartedDisk',
> > +                             '_raidSet')
> >          for (attr, value) in self.__dict__.items():
> > +
.
.
.

> >  
> >  class MultipathDevice(DMDevice):
> >      """ A multipath device """
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.