Re: [PATCH 2/2] Activate storage before looking up the hdiso source drive (#491781).

[Hans de Goede <hdegoede redhat com>]

On 04/02/2009 08:17 PM, Chris Lumens wrote:
> ---
>   storage/__init__.py |   32 +++++++++++++++++++++++++-------
>   1 files changed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/storage/__init__.py b/storage/__init__.py
> index 7c17ec8..56223df 100644
> --- a/storage/__init__.py
> +++ b/storage/__init__.py

<snip>

> +            else:
> +                if devspec.startswith("/dev/"):
> +                    dev = devspec[5:]
> +                else:
> +                    dev = devspec
> +
> +                name = udev_device_get_name(entry)
> +                if name == dev:
> +                    storage.protectedPartitions = [name]
> +                    break
> +

This won't work for doing installs with the devspec being a logical vol. In that case
we need to remove /dev/mapper from the devspec to get the name. Also to me this feels a
lot like the devicePathToDeviceName() function I introduced in my (proposed) cciss
handling patch. May I suggest to commit this as is and then later replace it by
devicePathToDeviceName() ? It seems a good idea to keep all the /dev/..... -> devicetree name
code in one place.

Regards,

Hans