Re: [PATCH4/6] Don't create array if already exists

[Hans de Goede <hdegoede redhat com>]

On 04/10/2009 03:33 PM, Jacek Danecki wrote:
> If array was created before this patch disallow to create new
> MDRaidArrayDevice object.
>
> It make an assumption that array for md member is created by function
> handleUdevMDMeberFormat.
> Maybe we can drop function addUdevMDDevice?

Attached patch:

-- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -998,6 +998,15 @@ class DeviceTree(object):
             except (KeyError, IndexError, ValueError) as e:
                 log.warning("invalid data for %s: %s" % (name, e))
                 return
+
+            if md_uuid:
+                md_array = self.getDeviceByUuid(md_uuid)
+                if md_array:
+                    log.debug("MD array md_uuid=%s already created" % (md_uuid))
+                    return md_array
+
+            if self.md_is_container(md_level):
+                 return device

             device = MDRaidArrayDevice(name,
                                        level=md_level,


Erm, shouldn't that last return be "return None" or just "return" ?

Regards,

Hans