Re: [PATCH] Minor aesthetic changes to the final section of lv dialog.

[Hans de Goede <hdegoede redhat com>]

Looks ok,

Regards,

Hans


On 04/10/2009 07:22 PM, Joel Granados Moreno wrote:
> Specifically:
> 1. Lines that run for more than 80 chars.
> 2. Saved a line on the error message.
> 3. The second line of if statements that run for two lines must start
>     two tabs after the tab spacing of the if statement.
> ---
>   iw/lvm_dialog_gui.py |   27 ++++++++++++++-------------
>   1 files changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
> index b8b31dd..35a3328 100644
> --- a/iw/lvm_dialog_gui.py
> +++ b/iw/lvm_dialog_gui.py
> @@ -735,19 +735,19 @@ class VolumeGroupEditor:
>                   try:
>                       templv.size = size
>                   except ValueError:
> -                    self.intf.messageWindow(_("Not enough space"),
> -                                            _("The logical volumes you have "
> -                                              "configured require %d MB, but the "
> -                                              "volume group only has %d MB.  Please "
> -                                              "either make the volume group larger "
> -                                              "or make the logical volume(s) smaller.")
> -                                              % (size, tempvg.size),
> -                                            custom_icon="error")
> +                    self.intf.messageWindow(
> +                            _("Not enough space"),
> +                            _("The logical volumes you have configured "
> +                              "require %d MB, but the volume group only has "
> +                              "%d MB.  Please either make the volume group "
> +                              "larger or make the logical volume(s) smaller.")
> +                              % (size, tempvg.size),
> +                            custom_icon="error")
>                       continue
>
>                   format = fmt_class(mountpoint=mountpoint)
>                   if self.lukscb and self.lukscb.get_active() and \
> -                   templv.format.type != "luks":
> +                        templv.format.type != "luks":
>                       newluks = format
>                       format = getFormat("luks",
>                                          passphrase=self.storage.encryptionPassphrase)
> @@ -755,10 +755,10 @@ class VolumeGroupEditor:
>               else:
>                   # existing lv
>                   if self.fsoptionsDict.has_key("formatcb") and \
> -                   self.fsoptionsDict["formatcb"].get_active():
> +                        self.fsoptionsDict["formatcb"].get_active():
>                       format = fmt_class(mountpoint=mountpoint)
>                       if self.lukscb and self.lukscb.get_active() and \
> -                       templv.format.type != "luks":
> +                            templv.format.type != "luks":
>                           newluks = format
>                           format = getFormat("luks",
>                                              device=templv.path,
> @@ -769,10 +769,11 @@ class VolumeGroupEditor:
>                       templv.format.mountpoint = mountpoint
>
>                   if self.fsoptionsDict.has_key("migratecb") and \
> -                   self.fsoptionsDict["migratecb"].get_active():
> +                        self.fsoptionsDict["migratecb"].get_active():
>                       format.migrate = True
>
> -                if self.fsoptionsDict.has_key("resizecb") and self.fsoptionsDict["resizecb"].get_active():
> +                if self.fsoptionsDict.has_key("resizecb") and \
> +                        self.fsoptionsDict["resizecb"].get_active():
>                       targetSize = self.fsoptionsDict["resizesb"].get_value_as_int()
>                       templv.targetSize = targetSize
>                       format.targetSize = targetSize