Re: [PATCH] Use the PV name when logging error messages.

[Hans de Goede <hdegoede redhat com>]

Looks good,

Regards,

Hans

On 04/14/2009 05:51 PM, Joel Granados Moreno wrote:
> ---
>   storage/devicetree.py |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index 8c41c50..7540ff2 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -1225,7 +1225,7 @@ class DeviceTree(object):
>                   pe_free = udev_device_get_vg_free_extents(info)
>                   pv_count = udev_device_get_vg_pv_count(info)
>               except (KeyError, ValueError) as e:
> -                log.warning("invalid data for %s: %s" % (name, e))
> +                log.warning("invalid data for %s: %s" % (device.name, e))
>                   return
>
>               vg_device = LVMVolumeGroupDevice(vg_name,
> @@ -1245,11 +1245,11 @@ class DeviceTree(object):
>                   lv_uuids = udev_device_get_lv_uuids(info)
>                   lv_sizes = udev_device_get_lv_sizes(info)
>               except KeyError as e:
> -                log.warning("invalid data for %s: %s" % (name, e))
> +                log.warning("invalid data for %s: %s" % (device.name, e))
>                   return
>
>               if not lv_names:
> -                log.debug("no LVs listed for VG %s" % name)
> +                log.debug("no LVs listed for VG %s" % device.name)
>                   return
>
>               lvs = []