[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH] Fix adding of fifth partition in UI.
- From: Chris Lumens <clumens redhat com>
- To: anaconda-devel-list redhat com
- Subject: Re: [PATCH] Fix adding of fifth partition in UI.
- Date: Tue, 21 Apr 2009 13:08:03 -0400
> This should fix bug I met when adding fifth (second logical) partition.
> Due to way we handle extended partition allocation, underlying ped
> object of former (before adding the 5th part) extended partition
> (e.g. /dev/sda4) contains trash and when we do nameUpdate of the partition it
> returns trash number which causes traceback later when trying to create
> /dev/sda231423234.
> ---
> storage/partitioning.py | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index 7a59747..663d1f1 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -569,6 +569,9 @@ def doPartitioning(storage, exclusiveDisks=None):
> # allocatePartitions() takes care of this for new partitions, but not
> # for pre-existing ones, so we update the name of all partitions here
> for part in partitions:
> + # needed because of XXX hack below
> + if part.isExtended:
> + continue
> part.updateName()
>
> # XXX hack -- if we created any extended partitions we need to add
Looks okay to me, and we just got a bug report about this so it's worth
pushing.
- Chris
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]