[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH] When catching an OSError, handle it as an object instead of a tuple (#497374).
- From: Chris Lumens <clumens redhat com>
- To: anaconda-devel-list redhat com
- Subject: Re: [PATCH] When catching an OSError, handle it as an object instead of a tuple (#497374).
- Date: Thu, 23 Apr 2009 13:37:21 -0400
> I'm a little confused by this hunk. Assigning from e.args to a tuple
> seems equivalent to the other uses of "except OSError, (num, _str):".
>
> Would it make sense to rewrite that except block to something like:
>
> except OSError as e:
> if (e.errno != 4):
> raise IOError, e.args
>
> for the sake of consistency / clarity? Or is that not worth the effort?
Yes, it makes sense to do so. I'll make that change.
- Chris
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]