[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/3] Collect network interfaces from NetworkManager (#493995)



On 04/29/2009 04:43 PM, David Cantrell wrote:
On 04/29/2009 04:42 PM, David Cantrell wrote:
On 04/29/2009 03:30 PM, Jeremy Katz wrote:
On Wednesday, April 29 2009, David Cantrell said:
Remove minihal.py and use NetworkManager to get a list of device names

I haven't looked too closely at this, but we're using minihal at least
also for list-harddrives-stub I thought

Not in the new storage code. At least grep didn't tell me we were.

And if I read that more closely, I would have caught 'stubs'. Yes, it is
in use for the list-harddrives-stub. Dunno, seems like we could get rid
of it there too.

Or not. I can modify my patch to not remove minihal.py for now. The main change I wanted to make was to how network.py was building the list of interfaces that we'll use and write out configuration data for. network.py was the last .py file that was importing minihal, so I thought that was a win too. Stupid stubs.

--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]