Re: PATCH: mkinitrd: FIX: nash unable to find dm devs by uuid or label (#480667)

[Peter Jones <pjones redhat com>]

Hans de Goede wrote:
> Peter Jones wrote:
> > > @@ -393,12 +392,12 @@ nashBdevIterNext(nashBdevIter *iterp, struct 
> > > nash_block_dev **dev)
> > >                  continue;
> > >              case POLLING:
> > >                  timeout = iter->timeout;
> > > -                if (block_process_one_uevent(iter->nc, &timeout, 
> > > &node)  > 0
> > > -                        && node) {
> > > +                rc = block_process_one_uevent(iter->nc, &timeout, 
> > > &node);
> > > +                if (rc > 0 && node) {
> > >                      *dev = node->bdev;
> > >                      return 1;
> > >                  }
> > > -                if (speczero(&timeout))
> > > +                if (rc <= 0)
> > >                      iter->state = DONE;
> > >                  continue;
> > >              case DONE:
> >
> > Ok, what have I missed here -- where are we handling a real timeout now?
>
> A real timeout has a return status of 0, notice the:
>                 if (rc <= 0)
>                      iter->state = DONE;
>
>
> Check.

OK, this one's fine to commit then.

--
        Peter

Growth for the sake of growth is the ideology of the cancer cell.