[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Strip invalid characters from autoamtically made VG/LV names (#483571).



On Thursday, February 05 2009, Chris Lumens said:
> We make names from mount points and host names, both of which can contain
> characters that are invalid to LVM.  The dash is the most promiment case here.
> Checks get run when the user enters these bad characters, but not when anaconda
> made up the names automatically.  So strip dashes out of the generated names
> before feeding them to LVM.

It looks okay, but rather than having the regex in a few places, we
should probably just have an lvm.safeLvmName() method?

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]