[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel5] More robust filtering of physical volumes in autopartioning (#475271)



>                                  len(partitions.autoClearPartDrives) == 0):
>                                  valid = 1
>                              else:
> -                                if not isinstance(r, partRequests.RaidRequestSpec):
> +                                if (isinstance(r, partRequests.PartitionSpec) and
> +                                    r.drive):

I can't ever remember how python works with putting conditionals across
two lines.  You may have to make those into one.

Looks fine, though.  It took me a minute to remember I'd even made a
patch for this.  Thanks for fixing the additional case there.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]