[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel5] More robust filtering of physical volumes in autopartioning (#475271)



Chris Lumens wrote:
                                 len(partitions.autoClearPartDrives) == 0):
                                 valid = 1
                             else:
-                                if not isinstance(r, partRequests.RaidRequestSpec):
+                                if (isinstance(r, partRequests.PartitionSpec) and
+                                    r.drive):

I can't ever remember how python works with putting conditionals across
two lines.  You may have to make those into one.
I thought it was just parenthesis continuation, not aware of any quirks of it. I have no problem with joing the line, now when I look at it, it would be more
readable with the and operator on the second line anyway.
Thanks for review


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]