Re: [PATCH] Rewrote parts of pkgorder script to improve it's speed. (#451083)

[Martin Gracik <mgracik redhat com>]

Of course I did test it :)
It returns the same results, in 1/2 time.

--
Martin Gracik


----- Original Message -----
From: "Chris Lumens" <clumens redhat com>
To: anaconda-devel-list redhat com
Sent: Wednesday, February 25, 2009 4:22:04 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: [PATCH] Rewrote parts of pkgorder script to improve it's speed. (#451083)

> Function printMatchingPkgs() was making glob.glob calls everytime it was used.
> Rewrote parts of the script to build the list of the packages just once,
> and then use fnmatch() to print the matching packages.
> Also some unnecessary import calls were removed.

Looks good to me.  Have you gotten a chance to test it out and verify it
gets the same results as the old pkgorder?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list redhat com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list