Re: [PATCH] Search for the bootloader without using the root path. (#452223)

[Joel Granados <jgranado redhat com>]

FYI, this happens when we are updating. not installing.
----- "Joel Granados" <jgranado redhat com> wrote:

> ----- "Martin Sivak" <msivak redhat com> wrote:
> 
> > Hi,
> >
> > what bootloader will it look for in the / of installer environment?
> 
> As I said, the reason for the device being in /dev/.. instead of
> /root/dev/... escapes me.  I don't know with certainty if its suppose
> to be one way or the other.   In any case, the worst that can happen
> is that the bootloader is not found.
> 
> > Shouldn't it be the same set of /dev files to iterate through?
> 
> As far as I know, it should.  But they are different in this code
> path.  Again, not sure why.
> 
> > Moreover, the set of config files is going to be different, as
> > installer media use syslinux or some other stuff..
> 
> nope, booty only looks for lilo, grub, and yaboot not syslinux.
> 
> I accept that the patch is a little hackish but I'm trying to avoid a
> possible bigger change.
> >
> > Martin
> >
> > ----- Original Message -----
> > From: "Joel Granados" <jgranado redhat com>
> > To: "Discussion of Development and Customization of the Red Hat
> Linux
> > Installer" <anaconda-devel-list redhat com>
> > Sent: Wednesday, January 7, 2009 3:31:25 PM GMT +01:00 Amsterdam /
> > Berlin / Bern / Rome / Stockholm / Vienna
> > Subject: Re: [PATCH] Search for the bootloader without using the
> root
> > path. (#452223)
> >
> >
> > ----- "Joel Granados Moreno" <jgranado redhat com> wrote:
> >
> > > ---
> > >  iw/upgrade_bootloader_gui.py     |    6 ++++++
> > >  textw/upgrade_bootloader_text.py |    6 ++++++
> > >  2 files changed, 12 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/iw/upgrade_bootloader_gui.py
> > > b/iw/upgrade_bootloader_gui.py
> > > index b9ba540..9667fad 100644
> > > --- a/iw/upgrade_bootloader_gui.py
> > > +++ b/iw/upgrade_bootloader_gui.py
> > > @@ -64,6 +64,12 @@ class UpgradeBootloaderWindow (InstallWindow):
> > >          (self.type, self.bootDev) = \
> > >
> > > checkbootloader.getBootloaderTypeAndBoot(dispatch.instPath)
> > >
> > > +        # We will try once more without a root path to see if we
> > can
> > > find the bootloader.
> > > +        if self.type is None and self.bootDev is None:
> > > +            (self.type, self.bootDev) = \
> > > +
> > > checkbootloader.getBootloaderTypeAndBoot(dispatch.instPath)
> > > +
> > > +
> > >
> > >          self.update_radio = gtk.RadioButton(None, _("_Update boot
> > > loader configuration"))
> > >          updatestr = _("This will update your current boot
> > loader.")
> > > diff --git a/textw/upgrade_bootloader_text.py
> > > b/textw/upgrade_bootloader_text.py
> > > index a332c8d..ae9af39 100644
> > > --- a/textw/upgrade_bootloader_text.py
> > > +++ b/textw/upgrade_bootloader_text.py
> > > @@ -31,6 +31,12 @@ class UpgradeBootloaderWindow:
> > >          (self.type, self.bootDev) = \
> > >
> > > checkbootloader.getBootloaderTypeAndBoot(dispatch.instPath)
> > >
> > > +        # We will try once more without a root path to see if we
> > can
> > > find the bootloader.
> > > +        if self.type is None and self.bootDev is None:
> > > +            (self.type, self.bootDev) = \
> > > +
> > > checkbootloader.getBootloaderTypeAndBoot(dispatch.instPath)
> >
> > I just realized the obvious mistake of leaving "dispatch.instPath"
> as
> > an argument.  I have already modified the patch so the function call
> > is "checkbootloader.getBootloaderTypeAndBoot()".  Any other issues?
> > > +
> > > +
> > >          blradio = RadioGroup()
> > >
> > >          (update, newbl, nobl) = (0, 0, 0)
> > > --
> > > 1.5.6.5
> > >
> > > _______________________________________________
> > > Anaconda-devel-list mailing list
> > > Anaconda-devel-list redhat com
> > > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> >
> > --
> > Joel Andres Granados
> > Red Hat / Brno Czech Republic
> >
> > _______________________________________________
> > Anaconda-devel-list mailing list
> > Anaconda-devel-list redhat com
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> >
> > _______________________________________________
> > Anaconda-devel-list mailing list
> > Anaconda-devel-list redhat com
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> 
> --
> Joel Andres Granados
> Red Hat / Brno Czech Republic

-- 
Joel Andres Granados
Red Hat / Brno Czech Republic