Re: [PATCH] Allow rebranding by excluding "the other" packages

[Jeremy Katz <katzj redhat com>]

On Jan 11, 2009, at 8:02 PM, Jeroen van Meeuwen wrote:
> This patch allows rebranding by excluding all other packages we know  
> about, using the PRODUCTSTR (instead of adding a --logopkg option).

Looks mostly good, just one question...

> +# The other -release and -logos packages will need to be excluded
> +for pkg in fedora redhat generic; do
> +    if [ "$pkg" != "$brandpkgname" ]; then
> +        EXCLUDEPKGS="$EXCLUDEPKGS ${pkg}-release ${pkg}-logos"
> +    fi
> +done

Do these actually need to be excluded now?  I think that with recent  
yum (which we end up depending on anyway), if you have a package set  
which includes
    fedora-release
    generic-release
and then you explicitly specify to install 'generic-release', provides  
which generic-release can do will get used "first" and then we'd only  
fall back to fedora-release if there was a provide which couldn't be  
satisfied.

Jeremy