Re: [PATCH] btrfs install support

[Eric Sandeen <sandeen redhat com>]

Radek Vykydal wrote:
> Hi Eric,
> 
> Eric Sandeen wrote:
>> Now that btrfs is in mainline, let's let anaconda play with
>> it too ;)  We still need btrfs.ko in the kernel, and btrfs
>> support in e2fsprogs.  I've got the latter patch submitted and
>> will just pull it into rawhide if upstream doesn't merge it soon.
>>   
> 
> we should also make sure that libblkid detects brtfs

It does already (in rawhide anyway, patch is sent upstream)

...

>> +        rc = iutil.execWithRedirect("mkfs.btrfs",
>> +				    ["-L", label, devicePath,
>>   
> 
> a typo here - missing closing square bracket after devicePath

Oops, thanks.


...

> in upd-instroot, we also need to explicitly specify (in KEEPFILE var)
> which files from added package we want to keep in the image
> something like:
> 
> diff --git a/scripts/upd-instroot b/scripts/upd-instroot
> index 23efc51..aa3dd2a 100755
> --- a/scripts/upd-instroot
> +++ b/scripts/upd-instroot
> @@ -341,6 +341,8 @@ lib/udev
>  sbin/*gfs*
>  sbin/arping
>  sbin/badblocks
> +sbin/btrfsctl
> +sbin/btrfsck
>  sbin/busybox.anaconda
>  sbin/clock
>  sbin/consoletype
> @@ -382,6 +384,7 @@ sbin/mkfs.jfs
>  sbin/mkfs.msdos
>  sbin/mkfs.vfat
>  sbin/mkfs.xfs
> +sbin/mkfs.btrfs
>  sbin/mkraid
>  sbin/mkreiserfs
>  sbin/mkswap

Ah that's right.... thanks!  I'll fix up and resend.

-Eric