[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCHES] Fix indentation
- From: David Cantrell <dcantrell redhat com>
- To: Discussion of Development and Customization of the Red Hat Linux Installer <anaconda-devel-list redhat com>
- Subject: Re: [PATCHES] Fix indentation
- Date: Tue, 13 Jan 2009 04:22:25 -1000
Jeremy Katz wrote:
> On Jan 11, 2009, at 7:59 PM, Jeroen van Meeuwen wrote:
>> here's a couple of patches that fix tab usage vs. the use of spaces in
>> some of the scripts that I needed to edit for the next patch.
>
> We've been generally shying away from mass re-indent patches just to
> avoid cluttering the history (git blame is useful; once you start
> re-indenting, it is massively less so). And with the fact that the
> scripts may be going away/getting rewritten/something, I'm not sure if
> we really want to reindent them at this point. If someone feels
> strongly otherwise, though, I really don't :-)
For these scripts, I think we can only improve readability (well, maybe
just a little).
Even though rewrites are in the future for these tools, I think we can
improve readability now and at least cope more easily with, "ugh, I have
to modify upd-instroot?"
I say we should apply them.
--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]