Re: [PATCH] Pyparted is used in the handling of dmraid sets.

[Joel Granados <jgranado redhat com>]

----- "Chris Lumens" <clumens redhat com> wrote:

> >  python-pyblock.spec |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/python-pyblock.spec b/python-pyblock.spec
> > index 33bbd88..53d6617 100644
> > --- a/python-pyblock.spec
> > +++ b/python-pyblock.spec
> > @@ -17,6 +17,7 @@ BuildRequires: dmraid-devel >= %{dmrver},
> libselinux-devel, libsepol-devel
> >  BuildRequires: zlib-devel, libbdevid >= 5.1.0
> >  Requires: python, device-mapper-libs >= %{dmver}, libselinux
> >  Requires: libbdevid, libbdevid-python, dmraid-libs >= %{dmrver}
> > +Requires: pyparted
> >  
> >  %description
> >  The pyblock contains Python modules for dealing with block
> devices.
> 
> Looks good to me.
> 
> By the way, pyblock is going to need some changing once we get the
> new
> pyparted into Fedora (which should be coming pretty soon - we're
> making
> tons of progress adapting anaconda to it, which is the blocker).

Yep, figured as much.  The good thing is that its not used a lot, so the change wont be that difficult.

> 
> In particular, stuff like this:
> 
>     import parted as _parted
>     ret = _parted.PedDevice.get(self.bdev.path)
> 
> Is going to have to change.  It would look more like this in the
> glorious future:
> 
>    import parted as _parted
>    ret = _parted.getDevice(self.bdev.path)
> 
> Simple, but it'll have to be done.

ok.  I'll make the changes.  I'll also look for more places where we use parted.

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Red Hat / Brno Czech Republic