Re: [PATCH] Avoid devices where the lvm metadata is not present (#481698)

[David Cantrell <dcantrell redhat com>]

The only thing I would change here is:

    if dev.strip().lower() == "unknown device"

I know it seems a bit pointless, but since we are relying on the output 
of external commands, a point release there could easily change the 
output from "unknown device" to something like "UnKnOwN dEvIcE" and 
we'll have to figure that out for RHEL 4.19.

Joel Granados Moreno wrote:
> ---
>  lvm.py |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/lvm.py b/lvm.py
> index 0439304..2b6f90e 100644
> --- a/lvm.py
> +++ b/lvm.py
> @@ -249,6 +249,11 @@ def pvlist():
>          except:
>              continue
>          log("pv is %s in vg %s, size is %s" %(dev, vg, size))
> +
> +        # We only append if the device is valid
> +        if dev == "unknown device":
> +            continue
> +
>          pvs.append( (dev, vg, size) )
>  
>      return pvs


--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI