Re: rawhide anaconda pychecker results

[David Cantrell <dcantrell redhat com>]

Hans de Goede wrote:
> Hi All,
>
> Can you all please take a look at these, and fix them (they are new 
> compared to F-10) or let me know if they are new false positives, then 
> I'll add them to the filter.
>
> iutil.py:395: Object (ppcType) has no attribute (items)

False positive, though I don't know how to make pychecker happy. 
items() gives you a list of 2-tuples of each key,value pair in the hash.

> kickstart.py:293: Object (kwargs) has no attribute (update)
> kickstart.py:298: Object (kwargs) has no attribute (update)

False positive.  For line 293:

    kwargs.update({
        'user': target.user,
        'pw': target.password
        })

Is the same as:

    kwargs['user'] = target.user
    kwargs['pw'] = target.password

> livecd.py:258: Object (fsdict) has no attribute (keys)
> livecd.py:267: Object (fsdict) has no attribute (keys)

False positive.  Beginning to think pychecker doesn't understand hash 
tables.

> packages.py:387: Object (publicBetas) has no attribute (items)

Same as false positive in iutil.py

> partRequests.py:504: Format string argument count (0) doesn't match 
> arguments (1)
> partRequests.py:685: Format string argument count (0) doesn't match 
> arguments (1)

Damn dirty lie or false positive.  The format string argument count does 
match.  But both of these cases use a hash table to list all the values 
for the format string since it's using the name identifier method for 
the format string.  Again with the hash table failures.

> partedUtils.py:549: Object (productUpgrades) has no attribute (has_key)

False positive.  Another hash table confuses pychecker.

> yuminstall.py:587: Statement appears to have no effect

VALID!  This seems like an actual real error.  We should remove this line.

> yuminstall.py:590: Function (_getConfig) doesn't support **kwArgs

YumSorter extends yum.YumBase and by the looks of it, this involves a 
hash table and I'm going to say pychecker is confused.  False positive.

--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI