Re: [PATCH 4/5] Display drive model and size in MB in partitioning UI (#460697)

[Steffen Maier <maier linux vnet ibm com>]

On 07/03/2009 08:39 AM, David Cantrell wrote:
> When a partition table is unreadable, anaconda displays a
> window explaining the situation and asks you if you would
> like to format the disk for use.  The existing message would
> only give the device node name (e.g., /dev/sda47).  This
> patch adds the drive model name and capacity to the message
> so confused users might know which disk anaconda is talking
> about.

> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index 08846f3..c199212 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -126,10 +126,18 @@ def questionInitializeDisk(intf=None, name=None):

> +                _("Error processing drive %s (%s  %-0.fMB).\n\n"
>                    "Maybe it needs to be reinitialized.  "

> +                  "YOU WILL LOSE ALL DATA ON THIS DRIVE!")
> +                % (name, dev.model, dev.getSize(),),

Just one little comment regarding disks on s390. With DASDs the model
and hence the size are unfortunately often the same for disks in the
system. Thus they would still not be distinguishable. What do you think
about adding the symlink name of /dev/disk/by-path as well? This would
unambiguously identify all kinds of disk (DASD and zFCP on s390).

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294