Re: [PATCH 2/2] Add kickstart fcoe command

[Chris Lumens <clumens redhat com>]

> diff --git a/kickstart.py b/kickstart.py
> index 474ecec..64eed2a 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -259,6 +259,15 @@ class ClearPart(commands.clearpart.FC3_ClearPart):
>  
>          return retval
>  
> +class Fcoe(commands.fcoe.F12_Fcoe):
> +    def parse(self, args):
> +        retval = commands.fcoe.F12_Fcoe.parse(self, args)
> +
> +        for fc in self.fcoe:
> +            self.handler.id.fcoe.addSan(nic=self.nic)
> +
> +        return retval
> +
>  class Firewall(commands.firewall.F10_Firewall):
>      def parse(self, args):
>          retval = commands.firewall.F10_Firewall.parse(self, args)
> @@ -984,6 +993,7 @@ commandMap = {
>          "deviceprobe": commands.deviceprobe.FC3_DeviceProbe,
>          "dmraid": DmRaid,
>          "driverdisk": commands.driverdisk.FC3_DriverDisk,
> +        "fcoe": Fcoe,
>          "firewall": Firewall,
>          "firstboot": Firstboot,
>          "graphical": commands.displaymode.FC3_DisplayMode,

This looks fine.  I also like to increase the version of pykickstart
that's required when I change kickstart.py in this way, too.  In this
case you can just bump the minor version by one.

- Chris