Re: [PATCH 5/5] Add missing LAYER2 and PORTNO handling for s390x.

[Steffen Maier <maier linux vnet ibm com>]

Looks all good, thanks David.

On 07/07/2009 04:17 AM, David Cantrell wrote:
> On Fri, 3 Jul 2009, Steffen Maier wrote:
>> On 07/03/2009 08:39 AM, David Cantrell wrote:
>>> libisys and loader lacked handling for the LAYER2 and PORTNO settings
>>> present on s390x systems.
>>>
>>> Also include the fix for #468755 to write layer2=1 rather than layer=2
>>> to the ifcfg-DEVICE file.
>>>
>>> Also include the fix for #471101 to include ARP=no when the device type
>>> is qeth and there are subchannels.

>> We should remove the writing of ARP=no entirely from anaconda.
> 
> Done.  Removed the block that writes ARP=no in the patch.  Updated version
> below:

> diff --git a/loader/net.c b/loader/net.c
> index 5b9593a..2da2384 100644
> - --- a/loader/net.c
> +++ b/loader/net.c

> @@ -1403,6 +1411,36 @@ int writeEnabledNetInfo(iface_t *iface) {
>          fprintf(fp, "CTCPROT=%s\n", iface->ctcprot);
>      }
> 
> +    if (iface->layer2 && !strcmp(iface->layer2, "1")) {
> +        osa_layer2 = 1;
> +    }

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294