[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Stop the cdrom device before ejecting (#505067)



> diff --git a/storage/devices.py b/storage/devices.py
> index 02c6945..5bfd31f 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2993,6 +2993,9 @@ class OpticalDevice(StorageDevice):
>          if not self.exists:
>              raise DeviceError("device has not been created", self.path)
>  
> +        #try to umount and close device before ejecting
> +        self.teardown()
> +
>          # Make a best effort attempt to do the eject.  If it fails, it's not
>          # critical.
>          fd = os.open(self.path, os.O_RDONLY | os.O_NONBLOCK)

Really?  That's it?  Okay, looks good to me.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]