Re: [PATCH 1/1] New is inconsistent in current main part screen.

[David Lehman <dlehman redhat com>]

On Fri, 2009-07-24 at 19:43 +0200, Joel Granados Moreno wrote:
> * iw/partition_gui.py (makepartCB, getScreen, newCB):  Change newCB to
> makepartCB and call it 'Partition'.  Its consistent with what the LVM
> and RAID buttons do.

Looks good. I'd be willing to bet that the button dates from a time when
partitions were the only devices we could create.

Dave

> ---
>  iw/partition_gui.py |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/iw/partition_gui.py b/iw/partition_gui.py
> index 847ea2c..684d771 100644
> --- a/iw/partition_gui.py
> +++ b/iw/partition_gui.py
> @@ -970,7 +970,7 @@ class PartitionWindow(InstallWindow):
>  
>              self.diskStripeGraph.selectSlice(device)
>  
> -    def newCB(self, widget):
> +    def makepartCB(self, widget):
>          device = self.storage.newPartition(fmt_type=self.storage.defaultFSType,
>                                             size=200)
>          self.editPartition(device, isNew=1)
> @@ -1361,9 +1361,9 @@ class PartitionWindow(InstallWindow):
>          buttonBox = gtk.HButtonBox()
>          buttonBox.set_layout(gtk.BUTTONBOX_SPREAD)
>  
> -        ops = ((_("Ne_w"), self.newCB),
> -               (_("_Edit"), self.editCB),
> +        ops = ((_("_Edit"), self.editCB),
>                 (_("_Delete"), self.deleteCB),
> +               (_("_Partition"), self.makepartCB),
>                 (_("Re_set"), self.resetCB),
>                 (_("R_AID"), self.makeraidCB),
>                 (_("_LVM"), self.makeLvmCB))