[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH] use python-meh for exception reporting
- From: Jeremy Katz <katzj redhat com>
- To: Discussion of Development and Customization of the Red Hat Linux Installer <anaconda-devel-list redhat com>
- Subject: Re: [PATCH] use python-meh for exception reporting
- Date: Tue, 28 Jul 2009 17:16:57 -0400
On Tuesday, July 28 2009, Chris Lumens said:
> The following series of patches changes anaconda over to using the new
> python-meh for exception handling. I have tested this, though something is
> bound to go wrong once we get all the packaging done and into a release.
> Before this can be pushed, the new python-meh package needs to make it in,
> though that's supposed to be in the works.
Reading through I didn't notice any real syntax-y problems and the
overall dropping a lot of code is good.
One minor nit (that probably isn't worth the effort it might take to
resolve) is that you're removing things in patches before you put their
replacement in. Which then means that bisecting would break across the
boundary.
Jeremy
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]