[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Make upgradeany boot option work again (#513227)



I like this, but ...

On Wednesday, July 29 2009, Radek Vykydal said:
> diff --git a/iw/examine_gui.py b/iw/examine_gui.py
> index 3a62e06..20af0c7 100644
> --- a/iw/examine_gui.py
> +++ b/iw/examine_gui.py
> @@ -93,7 +93,8 @@ class UpgradeExamineWindow (InstallWindow):
>          # we might get here after storage reset that obsoleted
>          # root device objects we had found
>          if not self.anaconda.id.rootParts:
> -            self.anaconda.id.rootParts = upgrade.findExistingRoots(self.anaconda)
> +            self.anaconda.id.rootParts = upgrade.findExistingRoots(self.anaconda, 
> +                                                                   upgradeany=flags.cmdline.has_key("upgradeany"))

You could get away without specifying the keyword for the arg and just passing
flags.cmdline.has_key("upgradeany") as the second arg.  It ends up being
just as clear and more concise to read

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]