[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/5] NM no longer exposes information through HAL (#514501).



> >  # Get a description string for a network device (e.g., eth0)
> >  def getNetDevDesc(dev):
> > +    from storage.udev import udev_get_block_device
> 
> Having this in the network code is ugly, but it'll do for now.  The
> whole set didn't really have anything jumping out at me as "wrong"
> although some of it makes me sad

I hate this line too, but it's easy enough to move some of this stuff
out of storage/udev.py and into (say) udev.py when we make it more
generic.

I suppose I could get started on that right away.  I was more interested
in getting anaconda up and installing again as fast as possible.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]