[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/4] Use gettext.ldngettext when necessary (#467603)





On 06/02/2009 10:20 PM, David Cantrell wrote:
On 06/01/2009 10:42 PM, Hans de Goede wrote:

<snip>

Missing "% len(availraidparts)" at the end.

Whoops. Updated patch attached. This one got tossed around too much.


Looks good now.

<snip>

Same here, are we ever going to have a maxTries of 1 ?

Regarding this and the above comment, the concern from the translators
is more about picking the correct words under different contexts. I
don't want to assume anything here and who knows what languages will be
added in the future with grammar rules I don't understand. I'd rather be
consistent now.


Fine by me.

<snip>

Here the singular form and the plural form of the string are the same,
so this
hunk is not needed.

Actually, the "%s of %s packages completed" is what bothered the
translators in the first place. Turns out this is impossible to
translate in all languages. They asked for the rewrite to "Packages
completed: %d of %d" and for the addition of a plural form. Some
languages have multiple plural forms depending on the values of
self.donepkgs and self.numpkgs. Crazy.

The main goal of this patch was to solve some problems that translators
kept hitting. Since we're early in the F-12 process, now seems like a
good time.


Ack, using _P here is fine by me, it seemed a bit weird to me, but if
this helps translators lets do it.

Regards,

Hans


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]