[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Enforcing matching rootfs type on LVs as well as for partitions (#504743)



> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index de3e3e5..5071ee0 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -138,6 +138,11 @@ def _scheduleLVs(anaconda, devs):
>          if request.fstype is None:
>              request.fstype = anaconda.id.storage.defaultFSType
>  
> +        # This is a little unfortunate but let the backend dictate the rootfstype
> +        # so that things like live installs can do the right thing
> +        if request.mountpoint == "/" and anaconda.backend.rootFsType != None:
> +            request.fstype = anaconda.backend.rootFsType
> +
>          # FIXME: move this to a function and handle exceptions
>          dev = anaconda.id.storage.newLV(vg=vg,
>                                          fmt_type=request.fstype,

Looks fine to me.  But you're right, putting this in multiple places
seems like we need to come up with a more generic approach.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]