[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Changes for using md on top isw format for F12



Hans de Goede wrote:
ok patches 1 and 2 look good.
About patch 3, you do not seem to do anything with the
level, memberDevices, totalDevices and bitmap arguments
to the new class' __init__ method may I suggest removing
the arguments?

Do you want to patch for patches 3 and 5, or just rewritten patches 3 and 5?

I know that we need a new mdadm and some fixes to grub,
but can you please be *A LOT* more verbose / clear about
what is exactly needed ? All your comments about this sofar
have been very vague, making them basically unusable.

For mdadm the most important commits are since devel3 version:

imsm: fix num_domains
	http://neil.brown.name/git?p=mdadm;a=commit;h=81062a36abd28d2354036da398c2e090fa759198
This patch is needed to make possible boot from raid1 by OROM.

super-intel: fix test on failed_disk_num.
	http://neil.brown.name/git?p=mdadm;a=commit;h=4291d691b66f65695b5b4be22b80fd00da73b544
This patch correct a patch "imsm: fix num_domains"

Monitor: don't get confused if utime is never set.
	http://neil.brown.name/git?p=mdadm;a=commit;h=4736b5dc7740ff38064c33b2460c1ee5c9aafa82
This patch is needed for events, which are not handled correctly in monitor mode for isw arrays.

imsm: kill "auto=" in brief_examine_super_imsm
	http://neil.brown.name/git?p=mdadm;a=commit;h=1124b3cf29dad544e8a5aa01e5f9e94e7be1765a
This patch is needed for kernels above 2.6.28.

RebuildMap: handle missing disks
	http://neil.brown.name/git?p=mdadm;a=commit;h=506ffd1e0bd08cc74f5177d4f4db7c66d7724f6a
This is fix for segfault after syfs_read.

imsm: support --examine --export
	http://neil.brown.name/git?p=mdadm;a=commit;h=9d84c8eac256345126f10628e4f13c07f7eece17
This patch adds support for parameters -E --export for isw format.

Also have you already filed bugs against grub anb mdadm
for this?

Yes. For mdadm: https://bugzilla.redhat.com/show_bug.cgi?id=499141, but Doug closed this bug as CANTFIX, so I did not fill the next bugs for mdadm.
For grub: https://bugzilla.redhat.com/show_bug.cgi?id=503698

Thanks for review.
Regards,
Jacek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]